GH-125866: Preserve Windows drive letter case in file URIs - #127138
Merged
barneygale merged 1 commit intoNov 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Stop converting Windows drive letters to uppercase in `urllib.request.pathname2url()` and `url2pathname()`. This behaviour is unnecessary and inconsistent with pathlib's file URI implementation.
zooba
approved these changes
Nov 22, 2024
zooba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The RFC also says that case should be preserved up until it's being processed by the file system, so we shouldn't be changing it here. (I still wouldn't backport this change, due to the trivial impact apart from breaking anyone who wrote a case-sensitive test that currently passes!)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Agreed! And thanks for the review. |
Sorry, something went wrong.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…hon#127138) Stop converting Windows drive letters to uppercase in `urllib.request.pathname2url()` and `url2pathname()`. This behaviour is unnecessary and inconsistent with pathlib's file URI implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop converting Windows drive letters to uppercase in urllib.request.pathname2url() and url2pathname(). This behaviour is unexpected and inconsistent with pathlib's file URI implementation.
📚 Documentation preview 📚: https://cpython-previews--127138.org.readthedocs.build/