FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127146: Emscripten: Skip segfaults in test suite by hoodmane · Pull Request #127151 · python/cpython · GitHub

/ cpython Public

gh-127146: Emscripten: Skip segfaults in test suite - #127151

Merged
freakboy3742 merged 6 commits into
python:mainfrom
hoodmane:fix-emscripten-test-segfaults
Dec 5, 2024
ConversationCommits (6)ChecksFiles changed
Merged

gh-127146: Emscripten: Skip segfaults in test suite#127151
freakboy3742 merged 6 commits into
python:mainfrom
hoodmane:fix-emscripten-test-segfaults

Conversation

hoodmane commented Nov 22, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

After this, Emscripten makes it all the way through the test suite when I run it locally.

bedevere-app Bot mentioned this pull request Nov 22, 2024
Closed
hoodmane force-pushed the fix-emscripten-test-segfaults branch 2 times, most recently from a281d38 to c11b73b Compare November 22, 2024 14:37
rhettinger removed their request for review November 22, 2024 20:16
mdboom requested changes Nov 23, 2024
View reviewed changes

mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry if this sounds overly pedantic, but isn't this "skipping tests that segfault" rather than "fixing tests that segfault"? It's a completely reasonably path to skip these tests and then come back later to fix them (if they matter), but I would suggest changing the PR title / commit message.

bedevere-app Bot commented Nov 23, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hoodmane commented Nov 23, 2024

Copy link
Copy Markdown
Contributor Author

As a mathematician I have no right to call anyone pedantic under practically any circumstances.

hoodmane changed the title gh-127146 Emscripten: Fix segfaults in test suite gh-127146 Emscripten: Skip segfaults in test suite Nov 23, 2024
pythongh-127146 Emscripten: Skip segfaults in test suite
c6425ea 
After this, Emscripten makes it all the way through the test suite when I run it
locally.
hoodmane force-pushed the fix-emscripten-test-segfaults branch from c11b73b to c6425ea Compare November 23, 2024 17:43

hoodmane commented Nov 23, 2024

Copy link
Copy Markdown
Contributor Author

Seems like I can remove a lot of these xfails if I set -sSTACK_SIZE=10mb instead of 5mb.

hoodmane commented Nov 23, 2024

Copy link
Copy Markdown
Contributor Author

Nevermind that is not true.

erlend-aasland changed the title gh-127146 Emscripten: Skip segfaults in test suite gh-127146: Emscripten: Skip segfaults in test suite Nov 26, 2024
freakboy3742 requested changes Nov 29, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The set of changes all looks fine to me.

However, if this is going to be a common mode of failure for tests (which this PR seems to indicate it will be), I'd rather see it pulled into a utility decorator, analogous to requires_subprocess (e.g., requires_full_stack?) so that the skip message is consistent.

hoodmane commented Nov 30, 2024

Copy link
Copy Markdown
Contributor Author

Okay @freakboy3742 I made a common method for the stack-overflow skips. I also updated the description according to @mdboom's complaint.

I have made the requested changes; please review again

bedevere-app Bot commented Nov 30, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@freakboy3742, @mdboom: please review the changes made to this pull request.

freakboy3742 requested changes Dec 2, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One possible cleanup that I should have found on my first pass. There's also a bunch of CI failures that I'm fairly sure are due to one misapplied test decorator.

Comment thread Lib/test/test_capi/test_misc.py Outdated
Comment thread Lib/test/mapping_tests.py Outdated

bedevere-app Bot commented Dec 2, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hoodmane commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

Okay, I have made the requested changes; please review again

bedevere-app Bot commented Dec 2, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@mdboom, @freakboy3742: please review the changes made to this pull request.

bedevere-app Bot requested a review from freakboy3742 December 2, 2024 12:04
erlend-aasland removed their request for review December 2, 2024 21:43
freakboy3742 approved these changes Dec 2, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - thanks for those fixes!

freakboy3742 commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

@mdboom Do the changes @hoodmane has made address your concerns? I'm happy to merge in the current state.

Eclips4 approved these changes Dec 3, 2024
View reviewed changes

Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

test_ast changes looks good to me.

hoodmane commented Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

If @mdboom doesn't come back to approve this, maybe you can merge it @freakboy3742? I think I addressed his comment...

freakboy3742 merged commit 43634fc into python:main Dec 5, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127146: Emscripten: Skip segfaults in test suite (python#127151
027ac70 
)

Added skips for tests known to cause problems when running on Emscripten. 
These mostly relate to the limited stack depth on Emscripten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 approved these changes
mdboom mdboom approved these changes
Eclips4 Eclips4 approved these changes
barneygale Awaiting requested review from barneygale barneygale is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL