Repository navigation
Speed-up lazy heapq import in collections - #127538
Merged
rhettinger merged 1 commit intoDec 3, 2024
Merged
rhettinger merged 1 commit into
rhettinger merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Dec 2, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
I hope that in future such optimization will not be needed. The lookup in sys.modules has the same cost as the lookup in globals(), but there is currently additional cost of checking that the module is not partially imported -- this is two additional attribute lookups (__spec__ and other). I am planning to optimize them out.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
There have been some similar optimizations before, and it is suggested to start with gh-110761 |
Sorry, something went wrong.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is faster to test for None than to go through the import logic to check sys.modules.
Baseline:
$ ./python.exe -m timeit -s 'from collections import Counter' -s 'c=Counter("abc")' 'c.most_common(1)' 500000 loops, best of 5: 481 nsec per loopPatched:
$ ./python.exe -m timeit -s 'from collections import Counter' -s 'c=Counter("abc")' 'c.most_common(1)' 500000 loops, best of 5: 400 nsec per loop