gh-127146: Mark test_bz2 tests with requires_subprocess - #127562
Closed
hoodmane wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
|
This doesn't seem quite right - iOS and Android don't support subprocesses, but have no problem implementing the bz2 tests. How are you seeing this problem manifest? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Traceback (most recent call last):
File "/home/rchatham/cpython/Lib/test/test_bz2.py", line 252, in testWrite
self.assertEqual(ext_decompress(f.read()), self.TEXT)
~~~~~~~~~~~~~~^^^^^^^^^^
File "/home/rchatham/cpython/Lib/test/test_bz2.py", line 34, in ext_decompress
return subprocess.check_output(['bunzip2'], input=data)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rchatham/cpython/Lib/subprocess.py", line 472, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
**kwargs).stdout
^^^^^^^^^
File "/home/rchatham/cpython/Lib/subprocess.py", line 554, in run
with Popen(*popenargs, **kwargs) as process:
~~~~~^^^^^^^^^^^^^^^^^^^^^^
File "/home/rchatham/cpython/Lib/subprocess.py", line 824, in __init__
raise OSError(
errno.ENOTSUP, f"{sys.platform} does not support processes."
)
OSError: [Errno 138] emscripten does not support processes.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Looking at ext_decompress: def ext_decompress(data):
global has_cmdline_bunzip2
if has_cmdline_bunzip2 is None:
has_cmdline_bunzip2 = bool(shutil.which('bunzip2'))
if has_cmdline_bunzip2:
return subprocess.check_output(['bunzip2'], input=data)
else:
return bz2.decompress(data)Looks like the problem is that shutil.which('bunzip2') returns something truthy for some reason. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
$ ./python.sh -c "import shutil; print(shutil.which('bunzip2'))"
/usr/bin/bunzip2
Okay the problem is that in node_entry.mjs I should do one or both of:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.