FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127553: Remove `TODO` comment in `_pydatetime._isoweek1monday` by bombs-kim · Pull Request #127564 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-127553: Remove TODO comment in _pydatetime._isoweek1monday - #127564

Merged
erlend-aasland merged 3 commits into
python:mainfrom
bombs-kim:fix-comment-pydatetime-isoweek1monday
Jan 4, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-127553: Remove TODO comment in _pydatetime._isoweek1monday#127564
erlend-aasland merged 3 commits into
python:mainfrom
bombs-kim:fix-comment-pydatetime-isoweek1monday

Conversation

bombs-kim commented Dec 3, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Dec 3, 2024
Closed
picnixz reviewed Dec 3, 2024
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cc @erlend-aasland

Comment thread Lib/_pydatetime.py Outdated
Comment on lines +2398 to +2399
# If the first weekday is after Thursday,
# ISO week 1 doesn't start until the next Monday

picnixz Dec 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This comment should be moved inside the if and I would only keep "ISO week 1 does not start until the next Monday" (or maybe no comment at all). Waiting for Erlend's opinion on this.

erlend-aasland Dec 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure the comment is needed. The code below speaks for itself, IMO. Let's just remove the XXX comment. After all, that is what the PR title says this PR should do.

bombs-kim Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@erlend-aasland Got it! I've reverted the change

picnixz changed the title gh-127553: Fix TODO comment in _pydatetime._isoweek1monday gh-127553: Remove TODO comment in _pydatetime._isoweek1monday Dec 3, 2024
picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 3, 2024

picnixz commented Dec 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I think it's better to backport that change so that users don't think we want to improve the implementation.

erlend-aasland merged commit e8b6b39 into python:main Jan 4, 2025

miss-islington-app Bot commented Jan 4, 2025

Copy link
Copy Markdown

Thanks @bombs-kim for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
pythongh-127553: Remove outdated TODO comment in _pydatetime (pythonG…
626a883 
…H-127564)

(cherry picked from commit e8b6b39)

Co-authored-by: Beomsoo Kim <beoms424@gmail.com>

bedevere-app Bot commented Jan 4, 2025

Copy link
Copy Markdown

GH-128500 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
pythongh-127553: Remove outdated TODO comment in _pydatetime (pythonG…
ad2612b 
…H-127564)

(cherry picked from commit e8b6b39)

Co-authored-by: Beomsoo Kim <beoms424@gmail.com>
bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 4, 2025

bedevere-app Bot commented Jan 4, 2025

Copy link
Copy Markdown

GH-128501 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 4, 2025
erlend-aasland pushed a commit that referenced this pull request Jan 4, 2025
[3.12] gh-127553: Remove outdated TODO comment in _pydatetime (GH-127564
06e4173 
) (#128501)

(cherry picked from commit e8b6b39)

Co-authored-by: Beomsoo Kim <beoms424@gmail.com>
erlend-aasland pushed a commit that referenced this pull request Jan 4, 2025
[3.13] gh-127553: Remove outdated TODO comment in _pydatetime (GH-127564
b2bacbb 
) (#128500)

(cherry picked from commit e8b6b39)

Co-authored-by: Beomsoo Kim <beoms424@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
pythongh-127553: Remove outdated TODO comment in _pydatetime (python#…
61c3e8a 
…127564)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127553: Remove outdated TODO comment in _pydatetime (python#…
91487d1 
…127564)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
erlend-aasland erlend-aasland approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL