FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127146: Resolve some minor problems in Emscripten tests by hoodmane · Pull Request #127565 · python/cpython · GitHub

/ cpython Public

gh-127146: Resolve some minor problems in Emscripten tests - #127565

Merged
freakboy3742 merged 1 commit into
python:mainfrom
hoodmane:fix-minor-emscripten-tests
Dec 4, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-127146: Resolve some minor problems in Emscripten tests#127565
freakboy3742 merged 1 commit into
python:mainfrom
hoodmane:fix-minor-emscripten-tests

Conversation

hoodmane commented Dec 3, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor
  • Emscripten has_strftime_extensions
  • fma doesn't handle negative zero correctly in Emscripten
  • Emscripten has similar limited stack depth to wasi and apple in test_marshall

pythongh-127146: Skip some minor problems in Emscripten tests
4bfeb60 
* Emscripten has_strftime_extensions
* fma doesn't handle negative zero correctly in Emscripten
* Emscripten has similar limited stack depth to wasi and apple in test_marshall
hoodmane requested a review from freakboy3742 December 3, 2024 14:34
bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 3, 2024
bedevere-app Bot mentioned this pull request Dec 3, 2024
Closed
hoodmane changed the title gh-127146: Skip some minor problems in Emscripten tests gh-127146: Resolve some minor problems in Emscripten tests Dec 3, 2024
freakboy3742 approved these changes Dec 4, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 These all make sense; thanks for the PR.

freakboy3742 merged commit 0f91078 into python:main Dec 4, 2024
hoodmane deleted the fix-minor-emscripten-tests branch December 4, 2024 10:16
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127146: Resolve some minor problems in Emscripten tests (pyt…
4fe70db 
…hon#127565)

Adjusts some Emscripten test exclusions regarding strftime, fma, and stack depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 approved these changes

Assignees

No one assigned

Labels

OS-emscripten skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL