FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-36589: Fix the error handling in curses.update_lines_cols() by ZackerySpytz · Pull Request #12766 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-36589: Fix the error handling in curses.update_lines_cols() - #12766

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-36589-curses-update_lines_cols
Nov 17, 2019
ConversationCommits (3)ChecksFiles changed
Merged

bpo-36589: Fix the error handling in curses.update_lines_cols()#12766
serhiy-storchaka merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-36589-curses-update_lines_cols

Conversation

ZackerySpytz commented Apr 10, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

serhiy-storchaka reviewed Nov 16, 2019
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suggest to keep the C function returning 0 on error, and make _curses.update_lines_cols returning None instead of 1 in normal case.

serhiy-storchaka commented Nov 16, 2019

Copy link
Copy Markdown
Member

Please add also a NEWS entry.

serhiy-storchaka added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Nov 17, 2019
serhiy-storchaka merged commit 2bc3434 into python:master Nov 17, 2019

miss-islington commented Nov 17, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington commented Nov 17, 2019

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2bc343417a4de83fa6998ff91303877734ecd366 3.8

miss-islington commented Nov 17, 2019

Copy link
Copy Markdown
Contributor

Sorry @ZackerySpytz and @serhiy-storchaka, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2bc343417a4de83fa6998ff91303877734ecd366 3.7

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-36589: Fix the error handling in curses.update_lines_cols(). (pyt…
40c37d4 
…honGH-12766)

Return None instead of 1.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-36589: Fix the error handling in curses.update_lines_cols(). (pyt…
3e0ef38 
…honGH-12766)

Return None instead of 1.
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Dec 31, 2020
[3.8] bpo-36589: Fix the error handling in curses.update_lines_cols(). (
4225c92 
pythonGH-12766)

Return None instead of 1..
(cherry picked from commit 2bc3434)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

bedevere-bot commented Dec 31, 2020

Copy link
Copy Markdown

GH-24023 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Jan 1, 2021
[3.8] bpo-36589: Fix the error handling in curses.update_lines_cols(). (
187785e 
GH-12766) (GH-24023)

Return None instead of 1.
(cherry picked from commit 2bc3434)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
serhiy-storchaka removed their assignment Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL