gh-126004: remove redundant safeguards for codecs handlers tests - #127680
Merged
picnixz merged 5 commits intoJan 23, 2025
Merged
gh-126004: remove redundant safeguards for codecs handlers tests#127680picnixz merged 5 commits into
picnixz merged 5 commits into
Conversation
encukou
reviewed
Dec 6, 2024
Comment thread
Lib/test/test_capi/test_codecs.py
Copy link
Copy Markdown
Member
|
I'd prefer merging this after the 3 fixes; at that point this would add additional assertions and remove the safe argument. |
Sorry, something went wrong.
vstinner
approved these changes
Jan 23, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.