FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: amend references starting with `!~` in gh-127054 · Pull Request #127684 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: amend references starting with !~ in gh-127054 - #127684

Merged
hugovk merged 2 commits into
mainfrom
unknown repository
Dec 6, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-101100: amend references starting with !~ in gh-127054#127684
hugovk merged 2 commits into
mainfrom
unknown repository

Conversation

ghost commented Dec 6, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

The references starting with !~ are not rendered correctly (as pointed out in #127054 (comment))

📚 Documentation preview 📚: https://cpython-previews--127684.org.readthedocs.build/

Docs: Fixup for PR gh-127054
3decd57 
The references starting with `!~` are not rendered correctly
(as pointed out in #127054 (comment))
bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 6, 2024

skirpichev commented Dec 6, 2024

Copy link
Copy Markdown
Member

I would rather suggest to revert the datastructures.rst change (and its backports!). Note that before - short method names were used.

CC @vstinner

picnixz changed the title Docs: Fixup for PR gh-127054 gh-101100: amend references starting with !~ in gh-127054 Dec 6, 2024
bedevere-app Bot mentioned this pull request Dec 6, 2024
Closed

ghost commented Dec 6, 2024

Copy link
Copy Markdown
Author

@skirpichev The purpose of this change is to suppress sphinx warnings (gh-101100). If the short method names are preferable, I think these should be changed to !append, !pop, etc.

skirpichev commented Dec 6, 2024

Copy link
Copy Markdown
Member

I think these should be changed to !append, !pop, etc.

Ah, indeed. That an option.

skirpichev added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 6, 2024
hugovk approved these changes Dec 6, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

hugovk merged commit 77a61c0 into python:main Dec 6, 2024

miss-islington-app Bot commented Dec 6, 2024

Copy link
Copy Markdown

Thanks @koyuki7w for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2024
pythongh-101100: amend references starting with !~ in pythongh-127054…
0acc5f3 
… (pythonGH-127684)

(cherry picked from commit 77a61c0)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2024
pythongh-101100: amend references starting with !~ in pythongh-127054…
959e932 
… (pythonGH-127684)

(cherry picked from commit 77a61c0)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>

bedevere-app Bot commented Dec 6, 2024

Copy link
Copy Markdown

GH-127692 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 6, 2024

bedevere-app Bot commented Dec 6, 2024

Copy link
Copy Markdown

GH-127693 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 6, 2024
hugovk pushed a commit that referenced this pull request Dec 6, 2024
[3.13] gh-101100: amend references starting with !~ in gh-127054 (G…
5d35d27 
…H-127684) (#127692)

gh-101100: amend references starting with `!~` in gh-127054 (GH-127684)
(cherry picked from commit 77a61c0)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
hugovk pushed a commit that referenced this pull request Dec 6, 2024
[3.12] gh-101100: amend references starting with !~ in gh-127054 (G…
cd46fb6 
…H-127684) (#127693)

gh-101100: amend references starting with `!~` in gh-127054 (GH-127684)
(cherry picked from commit 77a61c0)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
ghost deleted the doc-fix-2 branch December 6, 2024 14:25
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-101100: amend references starting with !~ in pythongh-127054…
417c5ce 
… (python#127684)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL