FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127691: add type checks when using `PyUnicodeError` objects by picnixz · Pull Request #127694 · python/cpython · GitHub

/ cpython Public

gh-127691: add type checks when using PyUnicodeError objects - #127694

Merged
encukou merged 13 commits into
python:mainfrom
picnixz:feat/codecs/check-types-127691
Dec 13, 2024
ConversationCommits (13)ChecksFiles changed
Merged

gh-127691: add type checks when using PyUnicodeError objects#127694
encukou merged 13 commits into
python:mainfrom
picnixz:feat/codecs/check-types-127691

Conversation

picnixz commented Dec 6, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

I think there will be CI failures so I'll fix them when the CI completes.

bedevere-app Bot mentioned this pull request Dec 6, 2024
Closed
picnixz marked this pull request as ready for review December 6, 2024 16:07
picnixz requested a review from iritkatriel as a code owner December 6, 2024 16:07
picnixz requested a review from encukou December 6, 2024 16:22
ZeroIntensity reviewed Dec 6, 2024
View reviewed changes
Comment thread Objects/exceptions.c

ZeroIntensity commented Dec 7, 2024

Copy link
Copy Markdown
Member

Will do a thorough review after I finish reviewing a few other things :)

ZeroIntensity reviewed Dec 7, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Objects/exceptions.c Outdated
Comment thread Objects/exceptions.c Outdated
Comment thread Objects/exceptions.c
Comment thread Objects/exceptions.c
Comment thread Objects/exceptions.c Outdated
picnixz commented Dec 7, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated
Comment thread Objects/exceptions.c Outdated
Comment thread Objects/exceptions.c Outdated
Comment thread Objects/exceptions.c
Comment thread Objects/exceptions.c Outdated
picnixz commented Dec 7, 2024
View reviewed changes
Comment thread Objects/exceptions.c Outdated
picnixz commented Dec 7, 2024
View reviewed changes
Comment thread Objects/exceptions.c Outdated
picnixz commented Dec 7, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated
picnixz commented Dec 7, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated
This was referenced Dec 10, 2024
Closed
Merged
encukou merged commit 8bc1818 into python:main Dec 13, 2024

encukou commented Dec 13, 2024

Copy link
Copy Markdown
Member

Thank you!

picnixz deleted the feat/codecs/check-types-127691 branch December 13, 2024 16:21
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127691: add type checks when using PyUnicodeError objects (p…
a7aa09b 
…ythonGH-127694)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity left review comments
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL