gh-118915: C API: Document frame locals proxies. - #127720
Merged
vstinner merged 5 commits intoDec 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
78 tasks
rruuaanng
reviewed
Dec 7, 2024
Copy link
Copy Markdown
Member
|
Overall I think it's okay, but I'm not the expert in docs. @ncoghlan would fit better in this role. Also maybe someone who's familiar with the docs like @AlexWaygood. |
Sorry, something went wrong.
AlexWaygood
self-requested a review
December 8, 2024 20:09
StanFromIreland
approved these changes
Dec 9, 2024
AlexWaygood
reviewed
Dec 9, 2024
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
Doc/c-api/frame.rst
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Dec 9, 2024
vstinner
reviewed
Dec 11, 2024
Comment thread
Doc/c-api/frame.rst
Outdated
vstinner
approved these changes
Dec 11, 2024
Copy link
Copy Markdown
|
Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 11, 2024
(cherry picked from commit dd9da73) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
|
GH-127831 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
vstinner
pushed a commit
that referenced
this pull request
Dec 11, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--127720.org.readthedocs.build/en/127720/c-api/frame.html#frame-locals-proxies