Repository navigation
gh-126719: Clarify math.fmod documentation - #127741
Merged
erlend-aasland merged 5 commits intoJan 4, 2025
Merged
erlend-aasland merged 5 commits into
erlend-aasland merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
reviewed
Dec 8, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
skirpichev
requested changes
Dec 9, 2024
skirpichev
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Note, that your diff looks much bigger, probably just due to formatting changes.
Please revert unrelated changes.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
@skirpichev The formatting changes are necessary, how do I add them, the line is otherwise too long? Please advise. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I don't think that patch from the issue has "too long" lines. |
Sorry, something went wrong.
This may be rejected by lint as the line is too long.
picnixz
reviewed
Dec 24, 2024
Comment thread
Doc/library/math.rst
Outdated
skirpichev
approved these changes
Dec 25, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
approved these changes
Dec 25, 2024
erlend-aasland
approved these changes
Jan 4, 2025
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2025
(cherry picked from commit f28d471) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2025
(cherry picked from commit f28d471) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-128491 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-128492 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
erlend-aasland
pushed a commit
that referenced
this pull request
Jan 4, 2025
erlend-aasland
pushed a commit
that referenced
this pull request
Jan 4, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 6, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was raised a month ago but has been forgotten about.
#126719
📚 Documentation preview 📚: https://cpython-previews--127741.org.readthedocs.build/