Repository navigation
gh-127065: Make methodcaller thread-safe and re-entrant (v2) - #127746
Merged
colesbury merged 29 commits intoDec 11, 2024
Merged
colesbury merged 29 commits into
colesbury merged 29 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Sam Gross <colesbury@gmail.com>
Co-authored-by: Sam Gross <colesbury@gmail.com>
eendebakpt
commented
Dec 8, 2024
Comment thread
Modules/_operator.c
| Py_VISIT(mc->args); | ||
| Py_VISIT(mc->kwds); | ||
| Py_VISIT(mc->vectorcall_args); | ||
| Py_VISIT(mc->vectorcall_kwnames); |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Note mc->vectorcall_kwnames is a tuple of strings, but the strings can be subclasses of str, so we need to visit this.
Sorry, something went wrong.
colesbury
reviewed
Dec 9, 2024
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. A few small comments below
Sorry, something went wrong.
Comment thread
Modules/_operator.c
Outdated
Comment thread
Modules/_operator.c
Outdated
Comment thread
Modules/_operator.c
Outdated
Comment thread
Modules/_operator.c
Outdated
colesbury
approved these changes
Dec 9, 2024
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
Sorry, something went wrong.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…GH-127746) The function `operator.methodcaller` was not thread-safe since the additional of the vectorcall method in pythongh-89013. In the free threading build the issue is easy to trigger, for the normal build harder. This makes the `methodcaller` safe by: * Replacing the lazy initialization with initialization in the constructor. * Using a stack allocated space for the vectorcall arguments and falling back to `tp_call` for calls with more than 8 arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #127245 for details.