FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127637: add tests for `dis` command-line interface by picnixz · Pull Request #127759 · python/cpython · GitHub

/ cpython Public

gh-127637: add tests for dis command-line interface - #127759

Merged
iritkatriel merged 5 commits into
python:mainfrom
picnixz:test/dis/127637
Dec 9, 2024
ConversationCommits (5)ChecksFiles changed
Merged

gh-127637: add tests for dis command-line interface#127759
iritkatriel merged 5 commits into
python:mainfrom
picnixz:test/dis/127637

Conversation

picnixz commented Dec 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We can decide to backport it or not.

picnixz requested a review from iritkatriel December 9, 2024 11:36
bedevere-app Bot mentioned this pull request Dec 9, 2024
Closed
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Outdated
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Outdated
picnixz requested a review from iritkatriel December 9, 2024 15:03
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Outdated
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Outdated
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Outdated
Comment thread Lib/test/test_dis.py
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py

iritkatriel commented Dec 9, 2024

Copy link
Copy Markdown
Member

We can decide to backport it or not.

We can backport, but I think it would need manual intervention to remove the new option you added last week.

iritkatriel added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 9, 2024

picnixz commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

We can backport, but I think it would need manual intervention to remove the new option you added last week.

Yes. But I wondered whether you wanted a NEWS entry as well in the backports (I didn't think of it before...)

picnixz commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

Since I would anyway need a manual backport (otherwise, the tests will fail and it will be harder to edit the PR), I'll remove the backports labels and will make them myself afterwards.

picnixz removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 9, 2024

iritkatriel commented Dec 9, 2024

Copy link
Copy Markdown
Member

We can backport, but I think it would need manual intervention to remove the new option you added last week.

Yes. But I wondered whether you wanted a NEWS entry as well in the backports (I didn't think of it before...)

The new entry doesn't need to change right?

We don't need this in what's new in.. because it's not user facing.

iritkatriel merged commit e85f2f1 into python:main Dec 9, 2024
iritkatriel added tests Tests in the Lib/test dir awaiting merge labels Dec 9, 2024
picnixz deleted the test/dis/127637 branch December 9, 2024 18:05

picnixz commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

I'll do the backports tomorrow.

picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
pythongh-127637: add tests for dis command-line interface (python#1…
0b929a7 
…27759)

bedevere-app Bot commented Dec 10, 2024

Copy link
Copy Markdown

GH-127780 is a backport of this pull request to the 3.12 branch.

picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
pythongh-127637: add tests for dis command-line interface (python#1…
8d55075 
…27759)

bedevere-app Bot commented Dec 10, 2024

Copy link
Copy Markdown

GH-127781 is a backport of this pull request to the 3.13 branch.

picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
pythongh-127637: add tests for dis command-line interface (python#1…
eb3ad0f 
…27759)
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
pythongh-127637: add tests for dis command-line interface (python#1…
2d880a1 
…27759)
iritkatriel pushed a commit that referenced this pull request Dec 10, 2024
[3.13] gh-127637: add tests for dis command-line interface (#127759) (
8bf5b89 
#127781)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127637: add tests for dis command-line interface (python#1…
1c803ca 
…27759)
picnixz added a commit that referenced this pull request Jan 18, 2025
[3.12] gh-127637: add tests for dis command-line interface (#127759) (
fbbef60 
#127780)
donbarbos mentioned this pull request Mar 13, 2025
Open
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

awaiting merge tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL