FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify ast docs to use a less confusing example for `ast.ParamSpec` by diceroll123 · Pull Request #127955 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Clarify ast docs to use a less confusing example for ast.ParamSpec - #127955

Merged
AlexWaygood merged 1 commit into
python:mainfrom
diceroll123:patch-1
Dec 15, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Clarify ast docs to use a less confusing example for ast.ParamSpec#127955
AlexWaygood merged 1 commit into
python:mainfrom
diceroll123:patch-1

Conversation

diceroll123 commented Dec 15, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes a syntactical typo. The syntax is valid and works fine at runtime, but I noticed that pyright was nitpicky about it.

📚 Documentation preview 📚: https://cpython-previews--127955.org.readthedocs.build/

ghost commented Dec 15, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 15, 2024

tomasr8 commented Dec 15, 2024

Copy link
Copy Markdown
Member

What is the pyright error? Since this is valid syntax, maybe it's something for pyright to fix instead?

AlexWaygood approved these changes Dec 15, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I agree this example is less confusing if the type alias definition passed as the string to ast.parse() is one that type checkers would accept if it were in user code

AlexWaygood changed the title Fix typo in ast docs: ParamSpec defaults Clarify ast docs to use a less confusing example for ast.ParamSpec Dec 15, 2024
AlexWaygood merged commit 7900a85 into python:main Dec 15, 2024
AlexWaygood added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 15, 2024

miss-islington-app Bot commented Dec 15, 2024

Copy link
Copy Markdown

Thanks @diceroll123 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 15, 2024

Copy link
Copy Markdown

Thanks @diceroll123 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 15, 2024

Copy link
Copy Markdown

Sorry, @diceroll123 and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7900a85019457c14e8c6abac532846bc9f26760d 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 15, 2024
Clarify ast docs to use a less confusing example for ast.ParamSpec (p…
347acc6 
…ythonGH-127955)

Fix typo in ast docs: ParamSpec defaults
(cherry picked from commit 7900a85)

Co-authored-by: Steve C <diceroll123@gmail.com>

bedevere-app Bot commented Dec 15, 2024

Copy link
Copy Markdown

GH-127959 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 15, 2024

AlexWaygood commented Dec 15, 2024

Copy link
Copy Markdown
Member

Oh, it's not relevant for 3.12 because ParamSpec defaults are new in 3.13

AlexWaygood removed the needs backport to 3.12 only security fixes label Dec 15, 2024
AlexWaygood removed their assignment Dec 15, 2024
AlexWaygood pushed a commit that referenced this pull request Dec 15, 2024
[3.13] Clarify ast docs to use a less confusing example for `ast.Para…
89f4b23 
…mSpec` (GH-127955) (#127959)

Clarify ast docs to use a less confusing example for `ast.ParamSpec` (GH-127955)

Fix typo in ast docs: ParamSpec defaults
(cherry picked from commit 7900a85)

Co-authored-by: Steve C <diceroll123@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Clarify ast docs to use a less confusing example for ast.ParamSpec (p…
38cc80a 
…ython#127955)

Fix typo in ast docs: ParamSpec defaults
willy-b mentioned this pull request Sep 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL