gh-126037: fix UAF in xml.etree.ElementTree.Element.find* when concurrent mutations happen - #127964
Merged
picnixz merged 7 commits intoMar 31, 2025
Merged
Conversation
vstinner
reviewed
Feb 4, 2025
Comment thread
Lib/test/test_xml_etree.py
vstinner
approved these changes
Mar 31, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Library/2024-12-15-15-07-22.gh-issue-126037.OyA7JP.rst
Outdated
Copy link
Copy Markdown
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker c57623c221d46daeaedfbf2b32d041fde0c882de 3.13 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @picnixz, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker c57623c221d46daeaedfbf2b32d041fde0c882de 3.12 |
Sorry, something went wrong.
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Mar 31, 2025
…n concurrent mutations happen (python#127964) We fix a use-after-free in the `find`, `findtext` and `findall` methods of `xml.etree.ElementTree.Element` objects that can be triggered when the tag to find implements an `__eq__` method that mutates the element being queried.
Copy link
Copy Markdown
|
GH-131931 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-131932 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
picnixz
added a commit
that referenced
this pull request
Mar 31, 2025
…en concurrent mutations happen (#127964) (#131932) gh-126037: fix UAF in `xml.etree.ElementTree.Element.find*` when concurrent mutations happen (#127964) We fix a use-after-free in the `find`, `findtext` and `findall` methods of `xml.etree.ElementTree.Element` objects that can be triggered when the tag to find implements an `__eq__` method that mutates the element being queried. (cherry picked from commit c57623c)
picnixz
added a commit
that referenced
this pull request
Mar 31, 2025
…en current mutations happen (#127964) (#131931) gh-126037: fix UAF in `xml.etree.ElementTree.Element.find*` when concurrent mutations happen (#127964) We fix a use-after-free in the `find`, `findtext` and `findall` methods of `xml.etree.ElementTree.Element` objects that can be triggered when the tag to find implements an `__eq__` method that mutates the element being queried. (cherry picked from commit c57623c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.