FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127896: Add missing document of `PySequence_In` · Pull Request #127979 · python/cpython · GitHub

/ cpython Public

gh-127896: Add missing document of PySequence_In - #127979

Merged
encukou merged 7 commits into
mainfrom
unknown repository
Dec 16, 2024
ConversationCommits (7)ChecksFiles changed
Merged

gh-127896: Add missing document of PySequence_In#127979
encukou merged 7 commits into
mainfrom
unknown repository

Conversation

ghost commented Dec 16, 2024 •
edited by ZeroIntensity
Loading

Copy link
Copy Markdown

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Dec 16, 2024
bedevere-app Bot mentioned this pull request Dec 16, 2024
Closed
skirpichev reviewed Dec 16, 2024
View reviewed changes
Comment thread Doc/c-api/sequence.rst Outdated
Update Doc/c-api/sequence.rst
2751a76 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev requested changes Dec 16, 2024
View reviewed changes

skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, but please add news and document that in whatsnew/3.14.rst (C API Changes->Deprecated).

ghost requested a review from skirpichev December 16, 2024 07:52

ghost commented Dec 16, 2024

Copy link
Copy Markdown
Author

Thanks. Added news and whatsnew entry.

encukou reviewed Dec 16, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated
skirpichev approved these changes Dec 16, 2024
View reviewed changes

skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I second on above suggestion.

Yuki Kobayashi and others added 3 commits December 16, 2024 19:14
ghost requested a review from encukou December 16, 2024 10:23
ZeroIntensity reviewed Dec 16, 2024
View reviewed changes
Comment thread Doc/c-api/sequence.rst

Alias for :c:func:`PySequence_Contains`.

.. deprecated:: 3.14

ZeroIntensity Dec 16, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We have this fancy thing these days:

Suggested change
.. deprecated:: 3.14
.. deprecated:: next

encukou Dec 16, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We do, and it makes backporting easier, but backporting a deprecation doesn't make much sense :)

encukou merged commit 52d552c into python:main Dec 16, 2024
ghost deleted the doc-fix-2 branch December 16, 2024 14:40
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127896: Add missing documentation of PySequence_In (python…
d94f9eb 
…GH-127979)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PySequence_In is not documented

3 participants

Back | FazBrowse Home | New Git URL