gh-127146: Emscripten clean up test suite - #127984
Merged
freakboy3742 merged 2 commits intoDec 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
A lot of these skips are no longer necessary.
hoodmane
requested review from
abalkin,
barneygale,
pganssle and
vsajip
as code owners
December 16, 2024 12:26
freakboy3742
approved these changes
Dec 17, 2024
freakboy3742
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
All makes sense; I've pushed one minor docstring update so the skip message reflects the skip condition.
Sorry, something went wrong.
Comment thread
Lib/test/test_unicode_file_functions.py
Outdated
freakboy3742
enabled auto-merge (squash)
December 17, 2024 00:30
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Removed test skips that are no longer required as a result of Emscripten updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of these skips are no longer necessary on Emscripten 3.1.74.