Repository navigation
[3.13] gh-127906: Fix Py_BUILD_ASSERT_EXPR() on Windows - #127994
Merged
vstinner merged 1 commit intoDec 16, 2024
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a compiler warning about an unnamed structure.
Copy link
Copy Markdown
Member
Author
|
Fix the following test_cext warning treated as an error: extension.c(56): error C2220: the following warning is treated as an error extension.c(56): warning C4116: unnamed type definition in parentheses |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I tested locally that this change fix python -m test test_cext -m test_build -v -u all -m test_build_c11. |
Sorry, something went wrong.
vstinner
enabled auto-merge (squash)
December 16, 2024 17:15
Copy link
Copy Markdown
Member
Author
|
Python 3.12 is not impacted. The main branch already contains the fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a compiler warning about an unnamed structure.