FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning by tomasr8 · Pull Request #128007 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning - #128007

Merged
brettcannon merged 15 commits into
python:mainfrom
tomasr8:importlib-deprecations
Jan 15, 2025
ConversationCommits (15)ChecksFiles changed
Merged

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning#128007
brettcannon merged 15 commits into
python:mainfrom
tomasr8:importlib-deprecations

Conversation

tomasr8 commented Dec 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Largely based on work done by @rashansmith, this adds deprecation warnings for the following importlib classes, methods and attributes (using the docs as the source of truth):

The deprecation messages are based on the docs. Warnings for DEBUG_BYTECODE_SUFFIXES and OPTIMIZED_BYTECODE_SUFFIXES are implemented using a module __getattr__.

Feedback welcome!

tomasr8 and others added 7 commits December 16, 2024 21:40
Add DeprecationWarning for path_mtime
d4844c5 
Co-authored-by: rashansmith <smith.rashan@gmail.com>
Add DeprecationWarning for ResourceLoader
cbe54a3 
Co-authored-by: rashansmith <smith.rashan@gmail.com>
Add DeprecationWarning for DEBUG_BYTECODE_SUFFIXES and OPTIMIZED_BYTE…
b73ad85 
…CODE_SUFFIXES.

Co-authored-by: rashansmith <smith.rashan@gmail.com>
Add DeprecationWarning for WindowsRegistryFinder
5375cf6 
Co-authored-by: rashansmith <smith.rashan@gmail.com>
Update tests
3306e7e
Add news entry
5c7c5e9
Unify quotes
7079bdd
bedevere-app Bot mentioned this pull request Dec 16, 2024
Closed
11 tasks done

tomasr8 commented Dec 16, 2024

Copy link
Copy Markdown
Member Author

cc @StanFromIreland

StanFromIreland reviewed Dec 16, 2024
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Two little things I noticed. I did not have time to go through the rest but it looks good in general.

Comment thread Lib/importlib/_bootstrap_external.py Outdated
Comment thread Lib/importlib/abc.py Outdated
tomasr8 and others added 2 commits December 16, 2024 22:55
Update Lib/importlib/abc.py
651e40e 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Fix tests
df86fcf
This was referenced Dec 18, 2024
Closed
Open
brettcannon requested changes Jan 6, 2025
View reviewed changes
Comment thread Lib/importlib/_bootstrap_external.py Outdated
Comment thread Lib/importlib/machinery.py Outdated
Comment thread Lib/importlib/machinery.py Outdated

bedevere-app Bot commented Jan 6, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

brettcannon commented Jan 6, 2025

Copy link
Copy Markdown
Member

Sorry about the review delay!

tomasr8 commented Jan 7, 2025

Copy link
Copy Markdown
Member Author

Sorry about the review delay!

No worries, and thanks for the review! I think I addressed your comments if you feel like having another look :)

I have made the requested changes; please review again

bedevere-app Bot commented Jan 7, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-app Bot requested a review from brettcannon January 7, 2025 23:37
brettcannon merged commit bd3baa8 into python:main Jan 15, 2025

brettcannon commented Jan 15, 2025

Copy link
Copy Markdown
Member

Thanks, @tomasr8 for bearing with me and my delayed reviews! 😅

tomasr8 deleted the importlib-deprecations branch January 15, 2025 06:59

tomasr8 commented Jan 15, 2025

Copy link
Copy Markdown
Member Author

No worries :) Thanks for the review!

graingert reviewed Jan 15, 2025
View reviewed changes
Comment thread Lib/importlib/abc.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
graingert graingert left review comments
StanFromIreland StanFromIreland left review comments
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL