Repository navigation
gh-128152: Update Argument Clinic to support empty lines - #128158
Closed
StanFromIreland wants to merge 1 commit into
Closed
StanFromIreland wants to merge 1 commit into
StanFromIreland wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
requested changes
Dec 21, 2024
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'm not sure it's the proper approach, although it may work. Empty lines could be incorrect directives depending on the DSL. In addition, please add tests for python input directives and for pure clinic directives to see if something changed.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Closing in favour of #128464. Thanks for the PR, though! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will skip the logic that follows after for empty lines so there should be no error. Assert is now no longer needed.
I don't this a NEWS worthy PR? If it is I can add an entry but I think a Skip NEWS label is just fine.