FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() by graingert · Pull Request #128172 · python/cpython · GitHub

/ cpython Public

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() - #128172

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
graingert:fix-resource-warnings-in-test-tasks
Dec 22, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop()#128172
kumaraditya303 merged 1 commit into
python:mainfrom
graingert:fix-resource-warnings-in-test-tasks

Conversation

graingert commented Dec 22, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 22, 2024
graingert mentioned this pull request Dec 22, 2024
Closed
7 tasks
graingert changed the title fix resource warnings in test_tasks.py gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() Dec 22, 2024
graingert marked this pull request as ready for review December 22, 2024 11:05
kumaraditya303 merged commit b66a4ad into python:main Dec 22, 2024
graingert deleted the fix-resource-warnings-in-test-tasks branch December 22, 2024 13:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
pythongh-127949: fix resource warnings in test_tasks.py (python#128172
2ad5c8f 
)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127949: fix resource warnings in test_tasks.py (python#128172
2cebf45 
)
graingert added the needs backport to 3.13 bugs and security fixes label Mar 27, 2025

miss-islington-app Bot commented Mar 27, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
pythongh-127949: fix resource warnings in test_tasks.py (pythonGH-1…
ac0688b 
…28172)

(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-app Bot commented Mar 27, 2025

Copy link
Copy Markdown

GH-131805 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
graingert added the needs backport to 3.12 only security fixes label Mar 27, 2025

miss-islington-app Bot commented Mar 27, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
pythongh-127949: fix resource warnings in test_tasks.py (pythonGH-1…
89abf3b 
…28172)

(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-app Bot commented Mar 27, 2025

Copy link
Copy Markdown

GH-131806 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 27, 2025
kumaraditya303 pushed a commit that referenced this pull request Mar 28, 2025
[3.13] gh-127949: fix resource warnings in test_tasks.py (GH-128172) (
924a6ce 
#131805)

gh-127949: fix resource warnings in `test_tasks.py` (GH-128172)
(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
kumaraditya303 added a commit that referenced this pull request Mar 28, 2025
[3.12] gh-127949: fix resource warnings in test_tasks.py (GH-128172) (
d4ddc03 
#131806)

* gh-127949: fix resource warnings in `test_tasks.py` (GH-128172)
(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL