gh-128262: Allow specialization of calls to classes with __slots__ - #128263
Merged
Fidget-Spinner merged 2 commits intoDec 31, 2024
Merged
gh-128262: Allow specialization of calls to classes with __slots__#128263Fidget-Spinner merged 2 commits into
Fidget-Spinner merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This looks like a nice improvement |
Sorry, something went wrong.
markshannon
reviewed
Dec 30, 2024
Comment thread
Python/bytecodes.c
Copy link
Copy Markdown
Member
|
Benchmarks shows a small improvement. |
Sorry, something went wrong.
markshannon
self-requested a review
December 30, 2024 22:03
markshannon
approved these changes
Dec 30, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark bm_float from pyperformance:
Mean +- std dev: [no_allow_slots] 107 ms +- 1 ms -> [allow_slots] 98.7 ms +- 0.8 ms: 1.08x faster
A significant improvement!