FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102471: convert decimal module to use PyLong_Export API (PEP 757) by skirpichev · Pull Request #128267 · python/cpython · GitHub

/ cpython Public

gh-102471: convert decimal module to use PyLong_Export API (PEP 757) - #128267

Merged
vstinner merged 7 commits into
python:mainfrom
skirpichev:decimal-use-PyLong_Export/127937
Jan 6, 2025
ConversationCommits (7)ChecksFiles changed
Merged

gh-102471: convert decimal module to use PyLong_Export API (PEP 757)#128267
vstinner merged 7 commits into
python:mainfrom
skirpichev:decimal-use-PyLong_Export/127937

Conversation

skirpichev commented Dec 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

For reviewers: in the history included version, where PyLong_Export always set digits.

Benchmark ref patch no-value
Decimal(1<<7) 735 ns not significant 721 ns: 1.02x faster
Decimal(1<<38) 809 ns 738 ns: 1.10x faster 846 ns: 1.05x slower
Decimal(1<<300) 1.93 us 2.05 us: 1.06x slower 1.99 us: 1.03x slower
Geometric mean (ref) 1.01x faster 1.01x slower

Benchmark hidden because not significant (1): Decimal(1<<3000)

benchmark code 
# export_bench.py
import pyperf
from decimal import Decimal as D

runner = pyperf.Runner()
i1, i2, i3, i4 = 1 << 7, 1 << 38, 1 << 300, 1 << 3000
runner.bench_func('Decimal(1<<7)', D, i1)
runner.bench_func('Decimal(1<<38)', D, i2)
runner.bench_func('Decimal(1<<300)', D, i3)
runner.bench_func('Decimal(1<<3000)', D, i4)

skirpichev requested a review from vstinner December 26, 2024 05:53
bedevere-app Bot mentioned this pull request Dec 26, 2024
Open
skirpichev mentioned this pull request Dec 26, 2024
Merged
serhiy-storchaka reviewed Dec 26, 2024
View reviewed changes
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
vstinner reviewed Dec 26, 2024
View reviewed changes
Comment thread Modules/_decimal/_decimal.c Outdated

skirpichev commented Jan 5, 2025

Copy link
Copy Markdown
Member Author

@vstinner, @serhiy-storchaka, please review.

I removed const's, added assert's, also handling value case now more simple. It seems, difference too small to measure on my system:

Benchmark ref patch only-qset_i64
int(Decimal(1<<7)) 620 ns 634 ns: 1.02x slower 634 ns: 1.02x slower
int(Decimal(1<<38)) 697 ns 728 ns: 1.04x slower 719 ns: 1.03x slower
int(Decimal(1<<300)) 2.02 us 2.04 us: 1.01x slower 2.04 us: 1.01x slower
Geometric mean (ref) 1.02x slower 1.02x slower

Benchmark hidden because not significant (1): int(Decimal(1<<3000))

(*) only-qset_i64 - current version.

@serhiy-storchaka, if you prefer runtime checks over asserts - I'll cache layout parameters in the decimal module state (though, seems odd for me).

serhiy-storchaka approved these changes Jan 6, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks.

vstinner approved these changes Jan 6, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I'm a little bit sad that the change makes the code a little bit slower, but I guess that's the price of abstraction.

vstinner merged commit 879d287 into python:main Jan 6, 2025

vstinner commented Jan 6, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

skirpichev deleted the decimal-use-PyLong_Export/127937 branch January 6, 2025 10:54
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-102471: convert decimal module to use PyLong_Export API (PEP…
5d8a701 
… 757) (python#128267)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL