FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127949: add docs for asyncio policy deprecation by kumaraditya303 · Pull Request #128269 · python/cpython · GitHub

/ cpython Public

gh-127949: add docs for asyncio policy deprecation - #128269

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
kumaraditya303:docs
Dec 26, 2024
ConversationCommits (6)ChecksFiles changed
Merged

gh-127949: add docs for asyncio policy deprecation#128269
kumaraditya303 merged 6 commits into
python:mainfrom
kumaraditya303:docs

Conversation

kumaraditya303 commented Dec 26, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Dec 26, 2024
Closed
7 tasks
bedevere-app Bot added the docs Documentation in the Doc dir label Dec 26, 2024
kumaraditya303 marked this pull request as ready for review December 26, 2024 09:50
picnixz reviewed Dec 26, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Doc/whatsnew/3.14.rst
Comment thread Doc/whatsnew/3.14.rst Outdated
Apply suggestions from code review
f057f8f 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
kumaraditya303 commented Dec 26, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Outdated
picnixz approved these changes Dec 26, 2024
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not. The only reason why I would suggest this is for users that do an online search and for IDEs that render Python docs based on the remote docs and that would miss the top-level warning.

kumaraditya303 commented Dec 26, 2024

Copy link
Copy Markdown
Contributor Author

If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not.

That was already done as part of individual PRs.

picnixz commented Dec 26, 2024

Copy link
Copy Markdown
Member

Perfect! (sorry since the diff didn't show it I wasn't aware of; I thought you waited for those changes actually or I didn't remember this). My approval remains then.

kumaraditya303 merged commit 3eb746a into python:main Dec 26, 2024
kumaraditya303 deleted the docs branch December 26, 2024 14:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127949: add docs for asyncio policy deprecation (python#128269)
dc60148
picnixz mentioned this pull request Mar 12, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
Eclips4 Eclips4 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner
hugovk Awaiting requested review from hugovk
+1 more reviewer
jnts1984 jnts1984 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-asyncio

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL