Let's put this into draft while you test out the change. Mark it as ready for review when you've got it working.

Let's proceed as-is, we can iterate later. I'll wait to merge until the 3.14a5 commit is pushed.

Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b05fa90b21dd01bb836285cdd41920320b09e681 3.13

Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b05fa90b21dd01bb836285cdd41920320b09e681 3.12

We didn't backport #129627, hence failing backports. Are backports worth it here?

A

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x has failed when building commit b05fa90.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/837) and take a look at the build logs.
4. Check if the failure is related to this commit (b05fa90) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/837

Failed tests:

• test_free_threading

Failed subtests:

• test_free_reference - test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 132, in test_free_reference
    self.assertIsNone(wr())
    ~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20006220090> is not None

We didn't backport #129627, hence failing backports. Are backports worth it here?

A

I think so, it would be good to keep (at least) the bugfix branches in sync, to make future backports and general maintenance easier.

Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b05fa90b21dd01bb836285cdd41920320b09e681 3.12

GH-130434 is a backport of this pull request to the 3.13 branch.

GH-130435 is a backport of this pull request to the 3.12 branch.