Repository navigation
gh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections - #128455
Merged
corona10 merged 2 commits intoJan 5, 2025
Merged
corona10 merged 2 commits into
corona10 merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
I don't believe this needs a news entry. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
As mentioned, the BOLT_COMMON_FLAGS will be subsequently used to fix #128472, e.g., zanieb@5448cd9 |
Sorry, something went wrong.
corona10
approved these changes
Jan 5, 2025
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 5, 2025
pythongh-128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (cherry picked from commit b60044b) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 5, 2025
pythongh-128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (cherry picked from commit b60044b) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Copy link
Copy Markdown
|
GH-128512 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-128513 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 6, 2025
pythongh-128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
pythongh-128455) Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a common flags variable that is used for both instrument and apply steps. Adds -update-debug-sections to the instrument step to resolve the BOLT warning.
This patch was originally authored by @indygreg as part of astral-sh/python-build-standalone#463
I dropped some additions to BOLT_COMMON_FLAGS, but will add them in a subsequent pull request.
Closes #128437