FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: mark up json.dump() using parameter list by erlend-aasland · Pull Request #128482 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Docs: mark up json.dump() using parameter list - #128482

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:docs/json-dump-param-list
Jan 4, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Docs: mark up json.dump() using parameter list#128482
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:docs/json-dump-param-list

Conversation

erlend-aasland commented Jan 4, 2025 •
edited by hugovk
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from hugovk January 4, 2025 13:28
bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jan 4, 2025

erlend-aasland commented Jan 4, 2025

Copy link
Copy Markdown
Contributor Author

What do you think, Hugo?

hugovk approved these changes Jan 4, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, looks good. A few non-blocking wording suggestions.

Comment thread Doc/library/json.rst Outdated
Comment thread Doc/library/json.rst Outdated
Comment thread Doc/library/json.rst Outdated
Comment thread Doc/library/json.rst Outdated
Comment thread Doc/library/json.rst Outdated
Apply suggestions from Hugo's review
4e545d0 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 4, 2025
erlend-aasland marked this pull request as ready for review January 4, 2025 15:40

erlend-aasland commented Jan 4, 2025

Copy link
Copy Markdown
Contributor Author

Thanks Hugo; it definitely looks better with those suggestions.

erlend-aasland enabled auto-merge (squash) January 4, 2025 15:41
erlend-aasland merged commit a0088b4 into python:main Jan 4, 2025
erlend-aasland deleted the docs/json-dump-param-list branch January 4, 2025 15:44

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
Docs: mark up json.dump() using parameter list (pythonGH-128482)
fd1a2cf 
(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Jan 4, 2025

Copy link
Copy Markdown

GH-128486 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
Docs: mark up json.dump() using parameter list (pythonGH-128482)
9b10e56 
(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 4, 2025

bedevere-app Bot commented Jan 4, 2025

Copy link
Copy Markdown

GH-128487 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 4, 2025
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
[3.13] Docs: mark up json.dump() using parameter list (GH-128482) (#1…
ff7ef94 
…28486)

(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
[3.12] Docs: mark up json.dump() using parameter list (GH-128482) (#1…
731fc40 
…28487)

(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 4, 2025
Docs: amend json.dump() post pythongh-128482
a93ad5b
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
Docs: amend json.dump() post gh-128482 (#128489)
87ee760
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
Docs: amend json.dump() post pythongh-128482 (pythonGH-128489)
59b58f2 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
Docs: amend json.dump() post pythongh-128482 (pythonGH-128489)
9704cd1 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
[3.13] Docs: amend json.dump() post gh-128482 (GH-128489) (#128493)
62b4ca0 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
[3.12] Docs: amend json.dump() post gh-128482 (GH-128489) (#128494)
e3e4852 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
Docs: mark up json.dump() using parameter list (python#128482)
5f7ba82 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
Docs: amend json.dump() post pythongh-128482 (python#128489)
1592145
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Docs: mark up json.dump() using parameter list (python#128482)
5aeee6f 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Docs: amend json.dump() post pythongh-128482 (python#128489)
7c67994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL