gh-75223: Deprecate undotted extensions in mimetypes.MimeTypes.add_type - #128638
Merged
hugovk merged 20 commits intoApr 28, 2025
Merged
gh-75223: Deprecate undotted extensions in mimetypes.MimeTypes.add_type#128638hugovk merged 20 commits into
hugovk merged 20 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Extensions that don't start with a dot will never be found by methods/functions that act on the registry, so we should stop users from mistakenly adding them. The one exception is the empty string extension. This could be in use to detect absent extensions, so instead of raising a ValueError we emit a warning.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
encukou
approved these changes
Apr 28, 2025
encukou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, thank you!
Sorry, something went wrong.
Comment thread
Lib/mimetypes.py
Outdated
Co-authored-by: Petr Viktorin <encukou@gmail.com>
hugovk
enabled auto-merge (squash)
April 28, 2025 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @encukou at #2895 (comment), we should deprecate this before raising a backwards-incompatible ValueError.
This PR is the first step to add a deprecation warning.
📚 Documentation preview 📚: https://cpython-previews--128638.org.readthedocs.build/