| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -47,6 +47,14 @@ get_thread_state(PyObject *module) | |
| } | ||
|
|
||
|
|
||
| #ifdef MS_WINDOWS | ||
| typedef HRESULT (WINAPI *PF_GET_THREAD_DESCRIPTION)(HANDLE, PCWSTR*); | ||
| typedef HRESULT (WINAPI *PF_SET_THREAD_DESCRIPTION)(HANDLE, PCWSTR); | ||
| static PF_GET_THREAD_DESCRIPTION pGetThreadDescription = NULL; | ||
| static PF_SET_THREAD_DESCRIPTION pSetThreadDescription = NULL; | ||
| #endif | ||
|
|
||
|
|
||
| /*[clinic input] | ||
| module _thread | ||
| [clinic start generated code]*/ | ||
| Expand Down Expand Up | @@ -2364,7 +2372,7 @@ Internal only. Return a non-zero integer that uniquely identifies the main threa | |
| of the main interpreter."); | ||
|
|
||
|
|
||
| #ifdef HAVE_PTHREAD_GETNAME_NP | ||
| #if defined(HAVE_PTHREAD_GETNAME_NP) || defined(MS_WINDOWS) | ||
| /*[clinic input] | ||
| _thread._get_name | ||
|
|
||
| Expand All | @@ -2375,6 +2383,7 @@ static PyObject * | |
| _thread__get_name_impl(PyObject *module) | ||
| /*[clinic end generated code: output=20026e7ee3da3dd7 input=35cec676833d04c8]*/ | ||
| { | ||
| #ifndef MS_WINDOWS | ||
| // Linux and macOS are limited to respectively 16 and 64 bytes | ||
| char name[100]; | ||
| pthread_t thread = pthread_self(); | ||
| Expand All | @@ -2389,11 +2398,26 @@ _thread__get_name_impl(PyObject *module) | |
| #else | ||
| return PyUnicode_DecodeFSDefault(name); | ||
| #endif | ||
| #else | ||
| // Windows implementation | ||
| assert(pGetThreadDescription != NULL); | ||
|
|
||
| wchar_t *name; | ||
| HRESULT hr = pGetThreadDescription(GetCurrentThread(), &name); | ||
| if (FAILED(hr)) { | ||
| PyErr_SetFromWindowsErr(0); | ||
| return NULL; | ||
| } | ||
|
|
||
| PyObject *name_obj = PyUnicode_FromWideChar(name, -1); | ||
| LocalFree(name); | ||
| return name_obj; | ||
| #endif | ||
| } | ||
| #endif // HAVE_PTHREAD_GETNAME_NP | ||
|
|
||
|
|
||
| #ifdef HAVE_PTHREAD_SETNAME_NP | ||
| #if defined(HAVE_PTHREAD_SETNAME_NP) || defined(MS_WINDOWS) | ||
| /*[clinic input] | ||
| _thread.set_name | ||
|
|
||
| Expand All | @@ -2406,6 +2430,7 @@ static PyObject * | |
| _thread_set_name_impl(PyObject *module, PyObject *name_obj) | ||
| /*[clinic end generated code: output=402b0c68e0c0daed input=7e7acd98261be82f]*/ | ||
| { | ||
| #ifndef MS_WINDOWS | ||
| #ifdef __sun | ||
| // Solaris always uses UTF-8 | ||
| const char *encoding = "utf-8"; | ||
| Expand Down Expand Up | @@ -2451,6 +2476,35 @@ _thread_set_name_impl(PyObject *module, PyObject *name_obj) | |
| return PyErr_SetFromErrno(PyExc_OSError); | ||
| } | ||
| Py_RETURN_NONE; | ||
| #else | ||
| // Windows implementation | ||
| assert(pSetThreadDescription != NULL); | ||
|
|
||
| Py_ssize_t len; | ||
| wchar_t *name = PyUnicode_AsWideCharString(name_obj, &len); | ||
| if (name == NULL) { | ||
| return NULL; | ||
| } | ||
|
|
||
| if (len > PYTHREAD_NAME_MAXLEN) { | ||
| // Truncate the name | ||
| Py_UCS4 ch = name[PYTHREAD_NAME_MAXLEN-1]; | ||
| if (Py_UNICODE_IS_HIGH_SURROGATE(ch)) { | ||
| name[PYTHREAD_NAME_MAXLEN-1] = 0; | ||
| } | ||
| else { | ||
| name[PYTHREAD_NAME_MAXLEN] = 0; | ||
| } | ||
| } | ||
|
|
||
| HRESULT hr = pSetThreadDescription(GetCurrentThread(), name); | ||
| PyMem_Free(name); | ||
| if (FAILED(hr)) { | ||
| PyErr_SetFromWindowsErr((int)hr); | ||
| return NULL; | ||
| } | ||
| Py_RETURN_NONE; | ||
| #endif | ||
| } | ||
| #endif // HAVE_PTHREAD_SETNAME_NP | ||
|
|
||
| Expand Down Expand Up | @@ -2594,6 +2648,31 @@ thread_module_exec(PyObject *module) | |
| } | ||
| #endif | ||
|
|
||
| #ifdef MS_WINDOWS | ||
| HMODULE kernelbase = GetModuleHandleW(L"kernelbase.dll"); | ||
| if (kernelbase != NULL) { | ||
|
Comment thread
Copy link
Copy Markdown
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityIf this check fails, we likely want to report a system error since everything is broken, but at least we should call DelAttr to remove the functions, since the function pointers will be null.
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualityset_name()/_get_name() is a minor feature of the _thread module, I would prefer to not prevent to import _thread if loading kernelbase.dll fails for whatever reason.
Oops, my code was wrong. Fixed.
Sorry, something went wrong.
All reactions
|
||
| if (pGetThreadDescription == NULL) { | ||
| pGetThreadDescription = (PF_GET_THREAD_DESCRIPTION)GetProcAddress( | ||
| kernelbase, "GetThreadDescription"); | ||
| } | ||
| if (pSetThreadDescription == NULL) { | ||
| pSetThreadDescription = (PF_SET_THREAD_DESCRIPTION)GetProcAddress( | ||
| kernelbase, "SetThreadDescription"); | ||
| } | ||
| } | ||
|
|
||
| if (pGetThreadDescription == NULL) { | ||
| if (PyObject_DelAttrString(module, "_get_name") < 0) { | ||
| return -1; | ||
| } | ||
| } | ||
| if (pSetThreadDescription == NULL) { | ||
| if (PyObject_DelAttrString(module, "set_name") < 0) { | ||
| return -1; | ||
| } | ||
| } | ||
| #endif | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| Expand Down | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.