FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-125722: Increase minimum supported Sphinx to 8.1.3 by AA-Turner · Pull Request #128922 · python/cpython · GitHub

/ cpython Public

GH-125722: Increase minimum supported Sphinx to 8.1.3 - #128922

Merged
AA-Turner merged 7 commits into
python:mainfrom
AA-Turner:docs/sphinx-8-1-3
Jan 20, 2025
ConversationCommits (7)ChecksFiles changed
Merged

GH-125722: Increase minimum supported Sphinx to 8.1.3#128922
AA-Turner merged 7 commits into
python:mainfrom
AA-Turner:docs/sphinx-8-1-3

Conversation

AA-Turner commented Jan 16, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

AA-Turner added docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 16, 2025
bedevere-app Bot mentioned this pull request Jan 16, 2025
Closed
AA-Turner commented Jan 16, 2025
View reviewed changes
Comment thread Doc/requirements-oldest-sphinx.txt Outdated

hugovk commented Jan 16, 2025

Copy link
Copy Markdown
Member

There's some if sphinx.version_info[:2] < (7, 2): in Doc/tools/extensions/c_annotations.py that can be removed.

AA-Turner commented Jan 16, 2025

Copy link
Copy Markdown
Member Author

There's some if sphinx.version_info[:2] < (7, 2): in Doc/tools/extensions/c_annotations.py that can be removed.

Done, I thought I'd gotten them all!

A

hugovk commented Jan 16, 2025

Copy link
Copy Markdown
Member

And remove the import sphinx :)

hugovk approved these changes Jan 16, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

AA-Turner merged commit d46b577 into python:main Jan 20, 2025

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3 (pythonGH…
eba5532 
…-128922)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner deleted the docs/sphinx-8-1-3 branch January 20, 2025 00:26

bedevere-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

GH-129037 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3 (pythonGH…
51fbfde 
…-128922)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2025

bedevere-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

GH-129038 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 20, 2025
AA-Turner added a commit that referenced this pull request Jan 20, 2025
[3.12] GH-125722: Increase minimum supported Sphinx to 8.1.3 (GH-128922…
6f19c6a 
…) (#129038)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Jan 20, 2025
[3.13] GH-125722: Increase minimum supported Sphinx to 8.1.3 (GH-128922…
5fe7650 
…) (#129037)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3 (python#1…
ee10fc4 
…28922)
AA-Turner mentioned this pull request Jan 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti ezio-melotti approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL