FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-59705: Make PYTHREAD_NAME_MAXLEN macro private by vstinner · Pull Request #128945 · python/cpython · GitHub

/ cpython Public

gh-59705: Make PYTHREAD_NAME_MAXLEN macro private - #128945

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:maxlen
Jan 18, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-59705: Make PYTHREAD_NAME_MAXLEN macro private#128945
vstinner merged 2 commits into
python:mainfrom
vstinner:maxlen

Conversation

vstinner commented Jan 17, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Rename PYTHREAD_NAME_MAXLEN to _PYTHREAD_NAME_MAXLEN.

pythongh-59705: Make PYTHREAD_NAME_MAXLEN macro private
de9d2fa 
Rename PYTHREAD_NAME_MAXLEN to _PYTHREAD_NAME_MAXLEN.
vstinner requested review from a team, corona10 and erlend-aasland as code owners January 17, 2025 14:13
bedevere-app Bot mentioned this pull request Jan 17, 2025
Closed
vstinner mentioned this pull request Jan 17, 2025
Merged

vstinner commented Jan 17, 2025

Copy link
Copy Markdown
Member Author

@zooba: Is it what you expected? To make the macro private?

corona10 approved these changes Jan 18, 2025
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm :)

chris-eibl reviewed Jan 18, 2025
View reviewed changes
Comment thread PC/pyconfig.h.in
vstinner enabled auto-merge (squash) January 18, 2025 14:47
vstinner merged commit 81159fc into python:main Jan 18, 2025
vstinner deleted the maxlen branch January 18, 2025 15:10

zooba commented Jan 20, 2025

Copy link
Copy Markdown
Member

I was thinking it didn't belong in pyconfig.h, but I didn't realise there was an autoconf switch picking values based on the platform.

So yeah, this is fine by me, but if it already existed in public then we probably have to leave it there :(

vstinner commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

I would prefer to only declare this macro in the internal C API. But I have no idea how to do that :-(

zooba commented Jan 20, 2025

Copy link
Copy Markdown
Member

I would prefer most of pyconfig.h be internal API, but that's long history now. We just have to live with it. Having the _PY prefix is the best option.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
pythongh-59705: Make PYTHREAD_NAME_MAXLEN macro private (python#128945)
bdf4c38 
Rename PYTHREAD_NAME_MAXLEN to _PYTHREAD_NAME_MAXLEN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chris-eibl chris-eibl left review comments
serhiy-storchaka serhiy-storchaka approved these changes
corona10 corona10 approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL