| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Not sure if it's me or not, but having that many files to review makes my GH interface crash (or load very slowly). Would it be possible to split this PR, at least per folders? just so that 1) it reduces the number of review requests 2) it helps us to review if possible? |
Sorry, something went wrong.
|
I have already already created 15 other PRs for groups of files with significant number of changes. But it is not worth to create a PR for 5 changed lines in 2 files. |
Sorry, something went wrong.
|
I non-recursively searched self.assert.*(issubclass|hasattr|startswith|endswith) inF:\dev\3x\Lib\test\test_t*.py (with IDLE) and found the same change candidates in the test_t*.py files included here (and only a couple of false positives). The replacements all looked right. This is the 1 AMD64 Android failure. ======================================================================
FAIL: testAssertHasAttr (test.test_unittest.test_case.Test_TestCase.testAssertHasAttr)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_unittest/test_case.py", line 803, in testAssertHasAttr
with self.assertRaises(self.failureException) as cm:
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: AssertionError not raised
|
Sorry, something went wrong.
|
The patch was initially created in 2016. It was then updated few years later, and just before creating this PR. Since the IDLE tests are located outside of the Lib/test tree, I missed new tests there. |
Sorry, something went wrong.
|
!buildbot ios |
Sorry, something went wrong.
|
!buildbot android |
Sorry, something went wrong.
|
!buildbot android |
Sorry, something went wrong.
|
Not sure what happened before with Android and iOS, but they both seem fine now. |
Sorry, something went wrong.
|
It was an issue in different tests which was fixed by #129133. No need to trigger buildbots. This PR is not emergent. It will be merged after merging all related PRs. Some changes can be extracted into separate PRs (like IDLE's). |
Sorry, something went wrong.
|
There have been practically no conflicts in the last few months. This means that this PR affects a very small part of the code that is actively changing. So I plan to merge this PR without backporting to 3.13. Probability of conflicts in future backports to 3.13 is low. |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
(cherry picked from commit 2602d8a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-134498 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
They provide better error report.
Only 1-2 lines are changed in the half of files, 3-4 lines in other quarter of files, and only in about 10 files there are more than 10 changed lines. So all this have been united in a single PR.