gh-129033: Remove _PyInterpreterState_SetConfig() function - #129048
Merged
vstinner merged 2 commits intoJan 20, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove _PyInterpreterState_GetConfigCopy() and _PyInterpreterState_SetConfig() private functions. PEP 741 "Python Configuration C API" added a better public C API: PyConfig_Get() and PyConfig_Set().
vstinner
force-pushed
the
remove_set_config
branch
from
76a55a6 to
27ebb23
Compare
January 20, 2025 12:48
Copy link
Copy Markdown
Member
Author
|
I got impacted by #129060 issue. I rebased my PR on top of it to fix the issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Oh, test_py_config_isoloated_per_interpreter() of test_capi.test_misc fails with in Free Threaded build: ImportError: module _testcapi does not support loading in subinterpreters |
Sorry, something went wrong.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 21, 2025
…hon#129048) Remove _PyInterpreterState_GetConfigCopy() and _PyInterpreterState_SetConfig() private functions. PEP 741 "Python Configuration C API" added a better public C API: PyConfig_Get() and PyConfig_Set().
youknowone
reviewed
Jul 29, 2025
Comment thread
Lib/test/support/__init__.py
| raise unittest.SkipTest("_testinternalcapi required") | ||
| config = _testinternalcapi.get_config() | ||
| return not _testcapi.config_get('code_debug_ranges') | ||
| return not bool(config['code_debug_ranges']) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The return statement added on Line 511 is shadowing this return.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Ooops, well spotted, I created #137379 to remove the dead code.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python Configuration C API" added a better public C API: PyConfig_Get() and PyConfig_Set().