GH-128563: Add new frame owner type for interpreter entry frames - #129078
Merged
markshannon merged 1 commit intoJan 21, 2025
Merged
GH-128563: Add new frame owner type for interpreter entry frames#129078markshannon merged 1 commit into
markshannon merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Jan 20, 2025
Copy link
Copy Markdown
Contributor
|
What's the point of FRAME_OWNED_BY_CSTACK now? It doesn't look like it's used at all. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpreter variable entry_frame is not accessible in the JIT, nor will it be in the tailcalling interpreter.
By adding a new "owner" kind for frames, we can mark entry frames as such without adding another field.