gh-91048: Also clear and set ts->asyncio_running_task with eager tasks - #129197
Merged
ambv merged 3 commits intoJan 23, 2025
Merged
gh-91048: Also clear and set ts->asyncio_running_task with eager tasks#129197ambv merged 3 commits into
ambv merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…r tasks This was missing from pythongh-124640. It's already covered by the new test_asyncio/test_free_threading.py in combination with the runtime assertion in set_ts_asyncio_running_task.
ambv
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
January 22, 2025 20:18
Comment thread
Modules/_asynciomodule.c
Outdated
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Comment thread
Modules/_asynciomodule.c
Outdated
kumaraditya303
approved these changes
Jan 23, 2025
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing from gh-124640. It's already covered by the new test_asyncio/test_free_threading.py in combination with the runtime assertion in set_ts_asyncio_running_task.