gh-91048: Improve example in asyncio-graph.rst doc - #129224
Merged
kumaraditya303 merged 1 commit intoJan 23, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sobolevn
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
January 23, 2025 13:42
StanFromIreland
approved these changes
Jan 23, 2025
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good idea, this will make it clearer for people less familiar with tasks.
Sorry, something went wrong.
kumaraditya303
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose adding an explicit name, because it is not clear what "Task-1" and "Task-2" are. Now with this explicit name it is more readable.
📚 Documentation preview 📚: https://cpython-previews--129224.org.readthedocs.build/