Repository navigation
Improve tests for _colorize.can_colorize() - #129234
hugovk merged 5 commits into
Conversation
Sorry, something went wrong.
hugovk
left a comment
There was a problem hiding this comment.
Thanks, looks good.
Sorry, something went wrong.
| import unittest | ||
| import unittest.mock | ||
| import _colorize | ||
| from test.support import force_not_colorized, make_clean_env |
There was a problem hiding this comment.
make_clean_env was moved to test.support from the PyREPL tests for use in this file (in #127877).
If we're not using it here any more, should we move it back, or leave it in case it's useful for others later?
Sorry, something went wrong.
There was a problem hiding this comment.
I do not know. I tried to use make_clean_env(), but we need to remove also NO_COLOR. On other hand, the only PYTHON* variable that needs to be removed is PYTHON_COLORS. Let it be there for now, and then we'll see.
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thanks @serhiy-storchaka for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
(cherry picked from commit 7907203) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-129265 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
No description provided.