FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython · GitHub

/ cpython Public

gh-112075: Remove critical section in dict.get - #129336

Merged
colesbury merged 3 commits into
python:mainfrom
eendebakpt:dict_get
Jan 28, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-112075: Remove critical section in dict.get#129336
colesbury merged 3 commits into
python:mainfrom
eendebakpt:dict_get

Conversation

eendebakpt commented Jan 27, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor
  • The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic.
  • Add a test for concurrent dict get and set operations

bedevere-app Bot mentioned this pull request Jan 27, 2025
Closed
colesbury enabled auto-merge (squash) January 28, 2025 21:33

colesbury commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Thanks!

colesbury merged commit 64c417d into python:main Jan 28, 2025
eendebakpt mentioned this pull request Feb 4, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
methane Awaiting requested review from methane methane is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL