| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
All makes sense; the only issue preventing merge is the RTD build failure... not sure what is going on there. I'll poke around and see what I can find out.
Sorry, something went wrong.
|
Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms. |
Sorry, something went wrong.
It almost certainly can be; but it will require the analog of platform.ios_ver()/platform.mac_ver() (et al) to expose the platform version identity. I imagine platform.emscripten_ver() (or wasm_ver, if there's an opportunity to share with WASI) will eventually exist; but it doesn't yet. |
Sorry, something went wrong.
|
We have sys._emscripten_info.emscripten_version. So we could add the following to support: def is_emscripten_lt(ver):
if not is_emscripten:
return False
ver_tuple = tuple(int(x) for x in ver.split("."))
return sys._emscripten_info.emscripten_version < ver_tupleand then put skipIf(is_emscripten_lt("4.0.1")). |
Sorry, something went wrong.
|
We'll eventually want to surface the version in platform for consistency, rather than the semi-private name on _sys. I'd also suggest using a tuple, rather than parsing the string at runtime, We could also consider making this a feature of is_emscripten , so that skipIf(is_emscripten()) is "skip any version" and skipIf(is_emscripten((4,0,1)) does an additional version check. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR emscripten-core/emscripten#23306 fixed stating pipes and will be released as part of Emscripten 4.0.2. I removed skips for various other testes that were fixed in 4.0.1 or earlier.