FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127146: Update test skips for Emscripten 4.0.1 by hoodmane · Pull Request #129375 · python/cpython · GitHub

/ cpython Public

gh-127146: Update test skips for Emscripten 4.0.1 - #129375

Merged
freakboy3742 merged 2 commits into
python:mainfrom
hoodmane:emscripten-skips-for-4.0.1
Jan 28, 2025
Merged

gh-127146: Update test skips for Emscripten 4.0.1#129375
freakboy3742 merged 2 commits into
python:mainfrom
hoodmane:emscripten-skips-for-4.0.1

Conversation

hoodmane commented Jan 27, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

PR emscripten-core/emscripten#23306 fixed stating pipes and will be released as part of Emscripten 4.0.2. I removed skips for various other testes that were fixed in 4.0.1 or earlier.

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jan 27, 2025
hoodmane requested a review from freakboy3742 January 27, 2025 17:40
hoodmane changed the title Update test skips for Emscripten 4.0.1 gh-127146: Update test skips for Emscripten 4.0.1 Jan 27, 2025
hoodmane force-pushed the emscripten-skips-for-4.0.1 branch from 9c27f1f to e2a80f3 Compare January 27, 2025 17:41

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All makes sense; the only issue preventing merge is the RTD build failure... not sure what is going on there. I'll poke around and see what I can find out.

zware commented Jan 28, 2025

Copy link
Copy Markdown
Member

Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms.

Copy link
Copy Markdown
Contributor

Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms.

It almost certainly can be; but it will require the analog of platform.ios_ver()/platform.mac_ver() (et al) to expose the platform version identity. I imagine platform.emscripten_ver() (or wasm_ver, if there's an opportunity to share with WASI) will eventually exist; but it doesn't yet.

freakboy3742 enabled auto-merge (squash) January 28, 2025 00:43
freakboy3742 merged commit 8e57877 into python:main Jan 28, 2025
hoodmane deleted the emscripten-skips-for-4.0.1 branch January 28, 2025 09:50

Copy link
Copy Markdown
Contributor Author

We have sys._emscripten_info.emscripten_version. So we could add the following to support:

def is_emscripten_lt(ver):
   if not is_emscripten:
      return False
   ver_tuple = tuple(int(x) for x in ver.split("."))
   return sys._emscripten_info.emscripten_version < ver_tuple

and then put skipIf(is_emscripten_lt("4.0.1")).

Copy link
Copy Markdown
Contributor

We'll eventually want to surface the version in platform for consistency, rather than the semi-private name on _sys. I'd also suggest using a tuple, rather than parsing the string at runtime,

We could also consider making this a feature of is_emscripten , so that skipIf(is_emscripten()) is "skip any version" and skipIf(is_emscripten((4,0,1)) does an additional version check.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL