FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-129393: Make 'sys.platform' return "freebsd" only on FreeBSD witho… by michael-o · Pull Request #129394 · python/cpython · GitHub

/ cpython Public

gh-129393: Make 'sys.platform' return "freebsd" only on FreeBSD witho… - #129394

Merged
vstinner merged 1 commit into
python:mainfrom
michael-o:sys.platform-freebsd-only
Jan 31, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-129393: Make 'sys.platform' return "freebsd" only on FreeBSD witho…#129394
vstinner merged 1 commit into
python:mainfrom
michael-o:sys.platform-freebsd-only

Conversation

michael-o commented Jan 28, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

…ut major version

Result:

osipovmi@deblndw011x:~/var/Projekte/cpython (main *+>)
$ /tmp/python-3.13/bin/python3
Python 3.14.0a4+ (heads/main-dirty:8e57877e3f4, Jan 28 2025, 10:01:48) [Clang 19.1.5 (https://github.com/llvm/llvm-project.git llvmorg-19.1.5-0-gab4b5a on freebsd
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.platform
'freebsd'
>>>

📚 Documentation preview 📚: https://cpython-previews--129394.org.readthedocs.build/

ghost commented Jan 28, 2025 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot mentioned this pull request Jan 28, 2025
Closed

michael-o commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

FWIW: I am a FreeBSD committer as well.

@emaste

michael-o force-pushed the sys.platform-freebsd-only branch from 7cecc55 to 242840a Compare January 28, 2025 09:31

encukou commented Jan 28, 2025

Copy link
Copy Markdown
Member

cc @vstinner as the FreeBSD contact

emaste commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

LGTM. Hopefully there's not too much fallout.

michael-o commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

LGTM. Hopefully there's not too much fallout.

Me as well, but this should stay on 3.14 and not be backported, even if I'd like to see that.

vstinner approved these changes Jan 28, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner commented Jan 28, 2025

Copy link
Copy Markdown
Member

IMO this change is backward compatible since it was recommended to use sys.platform.startswith('freebsd') to check if Python is running on FreeBSD. This code remains correct is sys.platform becomes "freebsd".

vstinner commented Jan 28, 2025

Copy link
Copy Markdown
Member

We did the same change on Linux when Linux was upgrade from Linux 2.x to Linux 3.x, and it went fine.

michael-o commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

IMO this change is backward compatible since it was recommended to use sys.platform.startswith('freebsd') to check if Python is running on FreeBSD. This code remains correct is sys.platform becomes "freebsd".

Oh great, I'd love to see this backported!

michael-o force-pushed the sys.platform-freebsd-only branch from 242840a to b9062bb Compare January 28, 2025 14:59

vstinner commented Jan 28, 2025

Copy link
Copy Markdown
Member

Oh great, I'd love to see this backported!

That would be backward incompatible, it's a bad idea. This change can only land into Python 3.14.

michael-o commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Oh great, I'd love to see this backported!

That would be backward incompatible, it's a bad idea. This change can only land into Python 3.14.

I am confused, doesn't this contract your previous statement: #129394 (comment)?

emaste commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Code "should" be checking startswith but I'd wager there are there cases that use the full string; they shouldn't be broken in an existing release.

michael-o commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

Code "should" be checking startswith but I'd wager there are there cases that use the full string; they shouldn't be broken in an existing release.

That's correct and this is what I have noticed with pyproject.toml.

michael-o commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

Is there anything required from me to merge this one?

michael-o force-pushed the sys.platform-freebsd-only branch from b9062bb to 0f19207 Compare January 28, 2025 19:45
vstinner merged commit e3eba8c into python:main Jan 31, 2025

vstinner commented Jan 31, 2025

Copy link
Copy Markdown
Member

Merged, thank you @michael-o.

michael-o deleted the sys.platform-freebsd-only branch January 31, 2025 10:05

michael-o commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

Merged, thank you @michael-o.

Thank you very much for the quick turnaround. Always a pleasure to work with pros!

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
pythongh-129393: Make 'sys.platform' return "freebsd" only on FreeBSD (…
fb9c825 
…python#129394)

Make 'sys.platform' return "freebsd" only on FreeBSD without major version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL