gh-93649: Split _testcapimodule.c into smaller files - #129400
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
requested review from
a team,
erlend-aasland and
markshannon
as code owners
January 28, 2025 13:10
* Move many functions from _testcapimodule.c into more specific files
in Modules/_testcapi/.
* Add files:
* Modules/_testcapi/frame.c
* Modules/_testcapi/function.c
* Modules/_testcapi/type.c
* In moved code:
* Replace get_testerror() with PyExc_AssertionError.
* Replace raiseTestError() with
PyErr_Format(PyExc_AssertionError, ...).
vstinner
force-pushed
the
split_testcapi
branch
from
bd6adbe to
78d4204
Compare
January 31, 2025 09:23
vstinner
marked this pull request as draft
January 31, 2025 13:11
Copy link
Copy Markdown
Member
Author
|
I have split this PR into smaller PRs: |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move many functions from _testcapimodule.c into more specific files in Modules/_testcapi/.
Add files:
In moved code: