gh-123471: make itertools.batched thread-safe by eendebakpt · Pull Request #129416 · python/cpython · GitHub

Make batched thread-safe using atomic loads and stores
Depends on gh-115999: Make list and tuple iteration more thread-safe. #128637 to make the iteration over the data = tuple(range(1000)) thread safe.
Also see Strategy for Iterators in Free Threading #124397

Issue: Make concurrent iteration over pairwise, combinations, permutations, cwr, product, etc. from itertools safe under free-threading #123471

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

eendebakpt added 2 commits January 28, 2025 20:09

Make itertools.batched thread-safe

070c877

enable tests

cc3c42b

eendebakpt requested a review from rhettinger as a code owner January 28, 2025 19:19

bedevere-app Bot added the awaiting review label Jan 28, 2025

bedevere-app Bot mentioned this pull request Jan 28, 2025

Make concurrent iteration over pairwise, combinations, permutations, cwr, product, etc. from itertools safe under free-threading #123471

Open

ZeroIntensity added the topic-free-threading label Jan 29, 2025

ZeroIntensity reviewed Jan 29, 2025

View reviewed changes

Comment thread Modules/itertoolsmodule.c

eendebakpt and others added 2 commits February 19, 2025 08:08

Merge branch 'main' into batched_ft

6452c72

📜🤖 Added by blurb_it.

0193795

eendebakpt requested a review from ZeroIntensity February 23, 2025 21:08

kumaraditya303 requested changes Mar 11, 2025

View reviewed changes

Comment thread Modules/itertoolsmodule.c

bedevere-app Bot added awaiting changes and removed awaiting review labels Mar 11, 2025

review comments

71fed22