Repository navigation
gh-129205: Update multiprocessing.forkserver to use os.readinto - #129425
Merged
vstinner merged 6 commits intoJan 30, 2025
Merged
vstinner merged 6 commits into
vstinner merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1 of 6 tasks
vstinner
approved these changes
Jan 30, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, I just suggest to remove the NEWS entry.
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Library/2025-01-28-22-11-41.gh-issue-129205.C-vE8S.rst
Outdated
| @@ -0,0 +1,2 @@ | |||
| :mod:`multiprocessing` forkserver now uses :func:`os.readinto` to read pid | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I don't think that it's worth it to document this change to end users. I suggest to remove this NEWS entry.
Sorry, something went wrong.
vstinner
enabled auto-merge (squash)
January 30, 2025 22:02
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single pre-allocated bytearray for temporary storage, os.readinto it avoiding non-mutable bytes.