FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-127432: add cross-build-linux as a required CI job by FFY00 · Pull Request #129459 · python/cpython · GitHub

/ cpython Public

GH-127432: add cross-build-linux as a required CI job - #129459

Merged
FFY00 merged 1 commit into
python:mainfrom
FFY00:gh-127432-add-required
Feb 13, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-127432: add cross-build-linux as a required CI job#129459
FFY00 merged 1 commit into
python:mainfrom
FFY00:gh-127432-add-required

Conversation

FFY00 commented Jan 29, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

pythonGH-127432: add cross-build-linux as a required CI job
eeb17f6 
Signed-off-by: Filipe Laíns <lains@riseup.net>
bedevere-app Bot mentioned this pull request Jan 29, 2025
Closed

AA-Turner commented Jan 30, 2025

Copy link
Copy Markdown
Member

Is there risk of flakiness from this job? It may be worth evaluating it for a few days to get a baseline, before requiring it for merge.

FFY00 commented Jan 30, 2025

Copy link
Copy Markdown
Member Author

There shouldn't be, we only run a subset of tests, which exercise most of the code that is relevant on cross builds. We can wait a couple days to evaluate it, though I don't currently have the bandwidth to keep an eye on other PRs to gauge it.

hugovk mentioned this pull request Jan 30, 2025
Merged

FFY00 commented Feb 8, 2025

Copy link
Copy Markdown
Member Author

We've waited a little bit, did anyone notice unexpected failures on this job in the meantime?

hugovk approved these changes Feb 12, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've not seen any issues with this one, I think we're good to merge.

FFY00 merged commit 2a0256f into python:main Feb 13, 2025
ZeroIntensity mentioned this pull request Feb 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL