FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-128563: Simplify recursion check in `_PyEval_EvalFrameDefault` by markshannon · Pull Request #129481 · python/cpython · GitHub

/ cpython Public

GH-128563: Simplify recursion check in _PyEval_EvalFrameDefault - #129481

Merged
markshannon merged 1 commit into
python:mainfrom
faster-cpython:earlier-check-recursion
Jan 31, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-128563: Simplify recursion check in _PyEval_EvalFrameDefault#129481
markshannon merged 1 commit into
python:mainfrom
faster-cpython:earlier-check-recursion

Conversation

markshannon commented Jan 30, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jan 30, 2025
Closed
Fidget-Spinner requested changes Jan 31, 2025
View reviewed changes
Comment thread Python/ceval.c


if (_Py_EnterRecursiveCallTstate(tstate, "")) {
assert(frame->owner != FRAME_OWNED_BY_INTERPRETER);

Fidget-Spinner Jan 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't you need to _Py_LeaveRecursiveCallPy after this as well?

At least from reading the code of exit_unwind.

markshannon Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No. We haven't called _Py_EnterRecursivePy

bedevere-app Bot commented Jan 31, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

markshannon commented Jan 31, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-app Bot commented Jan 31, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner: please review the changes made to this pull request.

bedevere-app Bot requested a review from Fidget-Spinner January 31, 2025 12:09
markshannon merged commit c3ae5c9 into python:main Jan 31, 2025
markshannon deleted the earlier-check-recursion branch January 31, 2025 12:12
mpage added a commit to mpage/cpython that referenced this pull request Feb 1, 2025
Revert "pythonGH-128563: Simplify recursion check in `_PyEval_EvalFra…
3edc57c 
…meDefault` (pythonGH-129481)"

This reverts commit c3ae5c9.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
pythonGH-128563: Simplify recursion check in `_PyEval_EvalFrameDefaul…
433f7df 
…t` (pythonGH-129481)

Simplify recursion check in _PyEval_EvalFrameDefault
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL