GH-128563: (Re)move some labels, to simplify implementing tailcalling interpeter. - #129525
Merged
markshannon merged 2 commits intoJan 31, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This should be fine. Can you please run benchmarks to make sure the added jumps don't affect perf? I don't think they should (they are jumps that should be always predicted), but I just want to be safe.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Any change in performance will just be noise or error. |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Jan 31, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from an earlier discussion: It complicates the code a lot if we need to be able to jump from generated code back into manually written labels and vice-versa.
This PR refactors the code so that there are only two transfers from the the code in ceval.c to bytecodes.c and none the other way,
for tier 1 (we can do much the same for tier 2 later).
The two transfers from PyEval_EvalDefault into the interpreter "loop" are: