FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-66113: Add unit tests for Turtle guionly by StanFromIreland · Pull Request #129532 · python/cpython · GitHub

Repository navigation

gh-66113: Add unit tests for Turtle guionly - #129532

Closed
StanFromIreland wants to merge 11 commits into
python:mainfrom
StanFromIreland:test-turtke
Closed

StanFromIreland wants to merge 11 commits into
python:mainfrom
StanFromIreland:test-turtke

Conversation

StanFromIreland commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Ill finish this off as #13494 has had 2 years of inactivity and no progress.

Co-authored-by: Sanyam Khurana <Sanyam@sanyamkhurana.com>
bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jan 31, 2025

Copy link
Copy Markdown
Member Author

ping @matrixise @taleinat

StanFromIreland commented Feb 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

It seems GitHub actions does not have the capabilities for running this test and must be run by a user. Any advice @terryjreedy (If I remember correctly you contributed quite a lot to turtle)

This would have to be a user only test.

Copy link
Copy Markdown
Member

The first failure is trying to open couldn't open a non-existent file. "D:\a\cpython\cpython\Lib\test/imghdrdata/python.gif": no such file or directory" Not on my system either for installed or repository versions. The others are for turtle.getscreen()._xxxx()calls raisingturtle.Terminator`. The latter also happens on my Windows system. Did the tests run for you? If so, which OS and which exact binary. What is the initial line when you run interactively?

To run just the test file, it needs the following added at the end.


if __name__ == '__main__':
    unittest.main()

I don't know anything in particular about testing turtle. I have only worked with turtledemo. Ping whoever has worked on test_turtle if not already.

StanFromIreland marked this pull request as draft February 2, 2025 09:38

Copy link
Copy Markdown
Member

@StanFromIreland Is there a specific reason you closed this rather than leave open for someone else to fix?

For anyone else: see my comment above. The new gui-needing test class could and should be added to the existing test_turtle.py by using support.requies('gui') in def setUpClass, as in IDLE tests. The missing image test could be deleted or fixed by finding the right url. I think IDLE somewhere references the file meant, and idlelib.icons has files. I neglected above to mention any or which turtle.getscreen().xxx() calls failed. turtle.getscreen()._blankimage() works for me today.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL