FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89867: string.Formatter auto numbering doc updates by dg-pb · Pull Request #129617 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-89867: string.Formatter auto numbering doc updates - #129617

Merged
encukou merged 4 commits into
python:mainfrom
dg-pb:string_formatter_parse_doc_update
Apr 30, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-89867: string.Formatter auto numbering doc updates#129617
encukou merged 4 commits into
python:mainfrom
dg-pb:string_formatter_parse_doc_update

Conversation

dg-pb commented Feb 3, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 3, 2025
bedevere-app Bot mentioned this pull request Feb 3, 2025
Closed

dg-pb commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity any chance you could check this one?

ZeroIntensity reviewed Apr 29, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not enough of an expert here to review, but the English and markup look mostly fine to me (see my one comment). I think @picnixz is the right person to tag, but he's going to be out for a little while last I heard.

Comment thread Doc/library/string.rst

dg-pb commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, english check is what I hoped for.

Regarding logic, maybe @encukou could have a look? This is just clarifying docs after #21767.

encukou approved these changes Apr 30, 2025
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thank you!

encukou merged commit a4b7128 into python:main Apr 30, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Apr 30, 2025
mth4saurabh pushed a commit to mth4saurabh/cpython that referenced this pull request Apr 30, 2025
pythongh-89867: string.Formatter auto numbering doc updates (pythonGH…
b9c5098 
…-129617)
dg-pb deleted the string_formatter_parse_doc_update branch April 30, 2025 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity left review comments
encukou encukou approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL