FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-121970: Extract ``implementation_detail`` into a new extension by AA-Turner · Pull Request #129663 · python/cpython · GitHub

/ cpython Public

GH-121970: Extract implementation_detail into a new extension - #129663

Merged
AA-Turner merged 2 commits into
python:mainfrom
AA-Turner:docs/implementation-detail
Feb 6, 2025
ConversationCommits (2)ChecksFiles changed
Merged

GH-121970: Extract implementation_detail into a new extension#129663
AA-Turner merged 2 commits into
python:mainfrom
AA-Turner:docs/implementation-detail

Conversation

AA-Turner commented Feb 4, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

I've tested both HTML and gettext output, both identical (given SOURCE_DATE_EPOCH is set).

The run() function is rewritten for clarity, and we sort the translation strings in dummy.html.

A

📚 Documentation preview 📚: https://cpython-previews--129663.org.readthedocs.build/

AA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 4, 2025
AA-Turner requested a review from hugovk as a code owner February 4, 2025 16:58
hugovk approved these changes Feb 6, 2025
View reviewed changes

hugovk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Comment thread Doc/tools/extensions/implementation_detail.py
Comment thread Doc/tools/extensions/implementation_detail.py
AA-Turner enabled auto-merge (squash) February 6, 2025 16:48
AA-Turner merged commit 4d56c40 into python:main Feb 6, 2025

miss-islington-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d56c40440c9fd4499d61d24977336d8cd8d8d83 3.13

miss-islington-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d56c40440c9fd4499d61d24977336d8cd8d8d83 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 6, 2025
[3.13] pythonGH-121970: Extract implementation_detail into a new …
6eea770 
…extension (pythonGH-129663)

(cherry picked from commit 4d56c40)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

GH-129739 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 6, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 6, 2025
[3.12] pythonGH-121970: Extract implementation_detail into a new …
0c50517 
…extension (pythonGH-129663)

(cherry picked from commit 4d56c40)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

GH-129740 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 6, 2025
AA-Turner deleted the docs/implementation-detail branch February 6, 2025 17:26
AA-Turner added a commit that referenced this pull request Feb 6, 2025
[3.13] GH-121970: Extract implementation_detail into a new extens…
aaf0581 
…ion (GH-129663) (#129739)

(cherry picked from commit 4d56c40)
AA-Turner added a commit that referenced this pull request Feb 6, 2025
[3.12] GH-121970: Extract implementation_detail into a new extens…
3dc5bce 
…ion (GH-129663) (#129740)

(cherry picked from commit 4d56c40)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
pythonGH-121970: Extract implementation_detail into a new extensi…
4cb458b 
…on (python#129663)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
pythonGH-121970: Extract implementation_detail into a new extensi…
3b2f592 
…on (python#129663)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

AA-Turner

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL